Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate tests that uses external_fixturepkg into a venv #783

Merged
merged 5 commits into from
Mar 24, 2024

Conversation

lieryan
Copy link
Member

@lieryan lieryan commented Mar 24, 2024

Description

Isolate tests that uses external_fixturepkg into a venv

This avoids modifying the test runtime environment itself.

Fixes #781

Checklist (delete if not relevant):

  • I have added tests that prove my fix is effective or that my feature works
  • I have updated CHANGELOG.md

@lieryan lieryan self-assigned this Mar 24, 2024
Copy link

codecov bot commented Mar 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.86%. Comparing base (1489d32) to head (aa0ffa6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #783   +/-   ##
=======================================
  Coverage   94.86%   94.86%           
=======================================
  Files         135      135           
  Lines       26383    26405   +22     
=======================================
+ Hits        25028    25050   +22     
  Misses       1355     1355           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This avoids modifying the test runtime environment itself.
@lieryan lieryan force-pushed the lieryan-781-venv-isolate branch from 849cd23 to 0d8fa6d Compare March 24, 2024 14:18
@lieryan lieryan changed the title Lieryan 781 venv isolate Isolate tests that uses external_fixturepkg into a venv Mar 24, 2024
@lieryan lieryan force-pushed the lieryan-781-venv-isolate branch from 51b1a90 to 6bbef1e Compare March 24, 2024 14:28
@lieryan lieryan enabled auto-merge March 24, 2024 14:35
@lieryan lieryan merged commit e261463 into master Mar 24, 2024
36 checks passed
@lieryan lieryan deleted the lieryan-781-venv-isolate branch March 24, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests that uses external_fixturepkg shoud run in their own venv
1 participant